MAC M1 and M2 issue for processor not found #1133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis pull request refactors frame processor loading to rely solely on the provided processor list, removing UI state dependency. It also simplifies macOS camera detection by removing checks for secondary indices and sets 'face_swapper' as the default processor. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @TamimDostyar - I've reviewed your changes - here's some feedback:
- The logic for loading frame processors based on UI state seems to have been removed; ensure the
frame_processorslist accurately reflects the intended configuration before this function is called. - Initializing
frame_processorswithface_swappermight activate it by default unexpectedly; consider leaving it empty. - Removing the macOS-specific camera detection logic might affect users with multiple cameras on Mac; verify this change doesn't cause regressions.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| except: | ||
| pass | ||
| except: | ||
| pass | ||
|
|
||
| def multi_process_frame(source_path: str, temp_frame_paths: List[str], process_frames: Callable[[str, List[str], Any], None], progress: Any = None) -> None: |
There was a problem hiding this comment.
suggestion (bug_risk): Avoid bare except usage.
Specify the exception types or log the error to avoid hiding issues and aid debugging.
Suggested implementation:
except Exception as e:
import logging # Ensure logging is imported at the top if not already
logging.exception(f"Error while loading frame processor module '{frame_processor}': {e}")Make sure to remove any duplicate import of logging if it already exists at the top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Fix camera detection and frame processor initialization issues on Mac M1/M2 systems
Bug Fixes:
Enhancements:
Chores: