Skip to content

Alerting: Comprehensive payload for Alertmanager convert API tests #110485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2025
Merged

Alerting: Comprehensive payload for Alertmanager convert API tests #110485

merged 2 commits into from
Sep 3, 2025

Conversation

yuri-tceretian
Copy link
Contributor

@yuri-tceretian yuri-tceretian commented Sep 2, 2025 •
edited
Loading

What is this feature?

  1. This PR updates integration tests for Alertmanager convert API to use configuration with all resources defined.
  2. API is updated to not remove Global configuration. Although the configuration is not used by Grafana Alertmanager, they are used when config is unmarshaled.

Why

Related https://github.com/grafana/alerting-squad/issues/1194

@yuri-tceretian yuri-tceretian requested a review from a team as a code owner September 2, 2025 21:22
@github-actions github-actions bot added this to the 12.2.x milestone Sep 2, 2025
@github-project-automation github-project-automation bot moved this to In review in Alerting Sep 2, 2025
@yuri-tceretian yuri-tceretian added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Sep 2, 2025
@yuri-tceretian yuri-tceretian force-pushed the yuri-tceretian/mimir-alertmanager-testing-payload branch from c0ffd87 to 5622579 Compare September 3, 2025 00:19
alexander-akhmetov
alexander-akhmetov approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@alexander-akhmetov alexander-akhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuri-tceretian yuri-tceretian merged commit 1e0aaa2 into main Sep 3, 2025
141 of 143 checks passed
@yuri-tceretian yuri-tceretian deleted the yuri-tceretian/mimir-alertmanager-testing-payload branch September 3, 2025 16:11
@github-project-automation github-project-automation bot moved this from In review to Done in Alerting Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akhmetov alexander-akhmetov alexander-akhmetov approved these changes

@JacobsonMT JacobsonMT Awaiting requested review from JacobsonMT

Assignees
No one assigned
Labels
area/alerting Grafana Alerting area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Alerting
Status: Done
Milestone
12.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@yuri-tceretian @alexander-akhmetov