Dashboards: Remove panel plugin provider from migrations #110477
Merged
+143
−518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
commented
Sep 2, 2025
ryantxu
commented
Sep 2, 2025
ryantxu
commented
Sep 2, 2025
konsalex
reviewed
Sep 3, 2025
| 25: V25, | ||
| 26: V26, | ||
| 27: V27, | ||
| 28: V28(panelProvider), |
There was a problem hiding this comment.
Technically we could even refactor v28 migrator to not have be a factory, and follow all the other migrators pattern except the ones with datasources
There was a problem hiding this comment.
yes... but i think we will need to refactor all of them to accept context.Context soon anyway
- Replace hardcoded plugin versions in V24 and V28 migrations with setting.BuildVersion - Add fallback to current dev version (12.2.0-pre) for test environments - Update test expectations and mock plugin versions to match dynamic versioning - Regenerate migration test output files with current versions
ryantxu
commented
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #108416, we added a
PanelPluginInfoProviderto the migrator -- we should avoid this unless it is absolutely necessary and is actually used to migrate the panels.From the current usage it is not necessary and would put real values into an invalid state