Skip to content

Chore: Add noMargin prop to Card components #110458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Chore: Add noMargin prop to Card components #110458

wants to merge 19 commits into from
+188 −322

Conversation

Clarity-89
Copy link
Contributor

What is this feature?

  • Add noMargin prop to remaining Card components to fix betterer violations
  • Remove the betterer Card noMargin rule and add it to the eslint config

Why do we need this feature?

To keep the UI consistent and reduce the number of betterer rules.

@Clarity-89 Clarity-89 self-assigned this Sep 2, 2025
@Clarity-89 Clarity-89 added the no-changelog Skip including change in changelog/release notes label Sep 2, 2025
@Clarity-89 Clarity-89 requested review from a team and grafanabot as code owners September 2, 2025 13:26
@Clarity-89 Clarity-89 requested review from Sergej-Vlasov, briangann, gelicia, kylebrandt, aocenas and ywzheng1 and removed request for a team September 2, 2025 13:26
@github-actions github-actions bot added this to the 12.2.x milestone Sep 2, 2025
@Clarity-89 Clarity-89 requested review from tomratcliffe, gillesdemey, konrad147, soniaAguilarPeiron and laurenashleigh and removed request for a team September 2, 2025 13:26
@github-project-automation github-project-automation bot moved this to In review in Alerting Sep 2, 2025
@adamyeats adamyeats moved this from Incoming to Needs Review in Partner Datasources Sep 4, 2025
@Clarity-89
Merge branch 'main' into chore/card-no-margin
31c6413 
# Conflicts:
#	.betterer.eslint.config.js
#	.betterer.results
#	eslint.config.js
@Clarity-89
Update suppressions
aea1509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

@beejeebus beejeebus Awaiting requested review from beejeebus beejeebus is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@alyssajoyner alyssajoyner Awaiting requested review from alyssajoyner alyssajoyner is a code owner automatically assigned from grafana/partner-datasources

@ivanortegaalba ivanortegaalba Awaiting requested review from ivanortegaalba ivanortegaalba is a code owner automatically assigned from grafana/dashboards-squad

@Sergej-Vlasov Sergej-Vlasov Awaiting requested review from Sergej-Vlasov Sergej-Vlasov is a code owner automatically assigned from grafana/dashboards-squad

@briangann briangann Awaiting requested review from briangann briangann is a code owner automatically assigned from grafana/plugins-platform-frontend

@gelicia gelicia Awaiting requested review from gelicia gelicia is a code owner automatically assigned from grafana/datapro

@kylebrandt kylebrandt Awaiting requested review from kylebrandt kylebrandt is a code owner automatically assigned from grafana/datapro

@aocenas aocenas Awaiting requested review from aocenas aocenas is a code owner automatically assigned from grafana/grafana-search-navigate-organise

@ywzheng1 ywzheng1 Awaiting requested review from ywzheng1 ywzheng1 is a code owner automatically assigned from grafana/grafana-search-navigate-organise

@tomratcliffe tomratcliffe Awaiting requested review from tomratcliffe tomratcliffe was automatically assigned from grafana/frontend-ops

@gillesdemey gillesdemey Awaiting requested review from gillesdemey gillesdemey is a code owner automatically assigned from grafana/alerting-frontend

@konrad147 konrad147 Awaiting requested review from konrad147 konrad147 is a code owner automatically assigned from grafana/alerting-frontend

@soniaAguilarPeiron soniaAguilarPeiron Awaiting requested review from soniaAguilarPeiron soniaAguilarPeiron is a code owner automatically assigned from grafana/alerting-frontend

@laurenashleigh laurenashleigh Awaiting requested review from laurenashleigh laurenashleigh is a code owner automatically assigned from grafana/alerting-frontend

At least 1 approving review is required to merge this pull request.

Assignees

@Clarity-89 Clarity-89

Labels
area/alerting Grafana Alerting area/explore area/frontend datasource/Azure Azure Monitor Datasource datasource/Loki no-changelog Skip including change in changelog/release notes
Projects
Alerting
Status: In review
Partner Datasources
Status: Needs Review
Milestone
12.2.x
Development

Successfully merging this pull request may close these issues.
1 participant
@Clarity-89