Allow alternatives to ForkingTestClassProcessor #32656
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefaultTestExecuter
hard-codes the use ofForkingTestClassProcessor
. This pull request introduces a way to use alternativeTestClassProcessor
.When running tests on
Scala.js
, forking is not an option, so Gradle Scala.js plugin needs to use a TestClassProcessor that does not fork.Without an extension point, the only way to make this work is to fork
DefaultTestExecuter
class and track changes to its Gradle original in a different repository just to be able to override one method - which is sub-optimal ;)Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective.<subproject>/src/test
) to verify logic../gradlew sanityCheck
../gradlew <changed-subproject>:quickTest
.Reviewing cheatsheet
Before merging the PR, comments starting with