Skip to content

Conversation

acocuzzo
Copy link
Contributor

A attribute descriptions in google/cloud/pubsub_v1/types in order to popular documentation properly:
following this format:

class BigQueryConfig(proto.Message):

@acocuzzo acocuzzo requested review from a team as code owners May 18, 2023 19:31
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels May 18, 2023
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few comments.

acocuzzo and others added 2 commits May 18, 2023 17:21
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
@acocuzzo acocuzzo merged commit 4607dca into main May 23, 2023
@acocuzzo acocuzzo deleted the add-attributes branch May 23, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants