Skip to content

fix: batch at most 1,000 ack ids per request #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2022
Merged

fix: batch at most 1,000 ack ids per request #802

merged 4 commits into from
Oct 8, 2022

Conversation

beltran
Copy link
Contributor

@beltran beltran commented Oct 8, 2022 •
edited by parthea
Loading

Brings parity with the java client. Allowing 2,500 ack ids in a single request can result in the request failing due to being too big.

Release-As: 2.13.10

@beltran beltran requested review from a team as code owners October 8, 2022 02:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Oct 8, 2022
@acocuzzo acocuzzo added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 8, 2022
acocuzzo
acocuzzo approved these changes Oct 8, 2022
View reviewed changes
Copy link
Contributor

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to change expected calls in test_dispatcher splitting_large_payload acks and modacks tests from 3 to 6.

@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 8, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 8, 2022
@acocuzzo acocuzzo merged commit 4361e67 into googleapis:main Oct 8, 2022
@release-please release-please bot mentioned this pull request Oct 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acocuzzo acocuzzo acocuzzo approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beltran @acocuzzo @parthea @yoshi-kokoro