Skip to content

fix: Add client library version to headers #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 28, 2024
Merged

fix: Add client library version to headers #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb4a12f
docs: small fix in Pub/Sub ingestion comments
gcf-owl-bot[bot] Feb 14, 2024
6a43e3c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 14, 2024
9336b14
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 14, 2024
4e50229
fix: Add client library version to headers
gcf-owl-bot[bot] Feb 24, 2024
576e212
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 24, 2024
6fac3d9
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions protos/google/pubsub/v1/pubsub.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ message SchemaSettings {
message IngestionDataSourceSettings {
// Ingestion settings for Amazon Kinesis Data Streams.
message AwsKinesis {
// Possible states for managed ingestion from Amazon Kinesis Data Streams.
// Possible states for ingestion from Amazon Kinesis Data Streams.
enum State {
// Default value. This value is unused.
STATE_UNSPECIFIED = 0;
Expand Down Expand Up @@ -312,8 +312,7 @@ message Topic {
// Output only. An output-only field indicating the state of the topic.
State state = 9 [(google.api.field_behavior) = OUTPUT_ONLY];

// Optional. Settings for managed ingestion from a data source into this
// topic.
// Optional. Settings for ingestion from a data source into this topic.
IngestionDataSourceSettings ingestion_data_source_settings = 10
[(google.api.field_behavior) = OPTIONAL];
}
Expand Down
3 changes: 1 addition & 2 deletions src/v1/publisher_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,8 +473,7 @@ export class PublisherClient {
* @param {google.pubsub.v1.Topic.State} request.state
* Output only. An output-only field indicating the state of the topic.
* @param {google.pubsub.v1.IngestionDataSourceSettings} [request.ingestionDataSourceSettings]
* Optional. Settings for managed ingestion from a data source into this
* topic.
* Optional. Settings for ingestion from a data source into this topic.
* @param {object} [options]
* Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
* @returns {Promise} - The promise which resolves to an array.
Expand Down