Skip to content

fix: fix typings for IAM methods #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 3, 2023
Merged

fix: fix typings for IAM methods #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ce0825
fix: fix typings for IAM methods
gcf-owl-bot[bot] Jul 27, 2023
c2a0965
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 27, 2023
35fbca8
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 27, 2023
5a04bec
Merge branch 'main' into owl-bot-copy
feywind Aug 3, 2023
fab4d47
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,493 changes: 1,493 additions & 0 deletions protos/protos.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

3,853 changes: 3,853 additions & 0 deletions protos/protos.js
View file
Open in desktop

Large diffs are not rendered by default.

292 changes: 292 additions & 0 deletions protos/protos.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion samples/createSubscriptionWithDeadLetterPolicy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ async function createSubscriptionWithDeadLetterPolicy(
console.log(
`Created subscription ${subscriptionNameOrId} with dead letter topic ${deadLetterTopicNameOrId}.`
);

console.log(
'To process dead letter messages, remember to add a subscription to your dead letter topic.'
);
Expand Down
1 change: 0 additions & 1 deletion samples/createSubscriptionWithExactlyOnceDelivery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ async function createSubscriptionWithExactlyOnceDelivery(
console.log(
`Created subscription ${subscriptionNameOrId} with exactly-once delivery.`
);

console.log(
'To process messages, remember to check the return value of ackWithResponse().'
);
Expand Down
1 change: 0 additions & 1 deletion samples/createSubscriptionWithOrdering.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ async function createSubscriptionWithOrdering(
console.log(
`Created subscription ${subscriptionNameOrId} with ordering enabled.`
);

console.log(
'To process messages in order, remember to add an ordering key to your messages.'
);
Expand Down
1 change: 0 additions & 1 deletion samples/publishAvroRecords.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ async function publishAvroRecords(topicNameOrId) {
console.log(`Unknown schema encoding: ${schemaEncoding}`);
break;
}

if (!dataBuffer) {
console.log(`Invalid encoding ${schemaEncoding} on the topic.`);
return;
Expand Down
1 change: 0 additions & 1 deletion samples/publishProtobufMessages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ async function publishProtobufMessages(topicNameOrId) {
console.log(`Unknown schema encoding: ${schemaEncoding}`);
break;
}

if (!dataBuffer) {
console.log(`Invalid encoding ${schemaEncoding} on the topic.`);
return;
Expand Down
1 change: 0 additions & 1 deletion samples/publishWithRetrySettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const {v1} = require('@google-cloud/pubsub');
const publisherClient = new v1.PublisherClient({
// optional auth parameters
});

async function publishWithRetrySettings(projectId, topicNameOrId, data) {
const formattedTopic = publisherClient.projectTopicPath(
projectId,
Expand Down
Loading