chore(storage): Only load from cgi what is required for Ruby 3.5
#30357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method will be gone in Ruby 3.5
In Ruby 3.5 most of the `cgi` gem will be removed. Only the various escape/unescape methods will be retained by default. https://bugs.ruby-lang.org/issues/21258
cgi what is required for Ruby 3.5cgi what is required for Ruby 3.5
|
Can someone take a look? The actual change is really small, just changing a require to a more specific one in two places, the rest is test-only. Thanks! |
|
I'm looking at it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.5 most of the
cgigem will be removed. Only the various escape/unescape methods will be retained by default.https://bugs.ruby-lang.org/issues/21258
CGI.parseis used only in tests and can be replaced byURI.decode_www_form, which returns an array of arrays. So it just needs to be converted to a hash before.CGI.escapeis available by requiringcgi/escapeand doesn't emit a warning on Ruby 3.5Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
bundle exec rake ciin the gem subdirectory.closes: None