Skip to content

Remove classifier for Python 3.4 for end-of-life. #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2019
Merged

Remove classifier for Python 3.4 for end-of-life. #7535

merged 2 commits into from
Mar 20, 2019

Conversation

crwilcox
Copy link
Contributor

Python 3.4 has reached EOL. https://www.python.org/dev/peps/pep-0429/

At this point we should remove the classifier for 3.4 and discourage its use. This change doesn't prevent users from installing this library on 3.4. Doing so would require rev-ing versions of our libraries and create a good deal of noise. My suggestion is that we modify python_requires as other breaking changes come, removing 3.4 at that point.

@crwilcox crwilcox requested a review from tswast as a code owner March 19, 2019 13:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2019
@tseaver
Copy link
Contributor

tseaver commented Mar 19, 2019 •
edited
Loading

@crwilcox

My suggestion is that we modify python_requires as other breaking changes come, removing 3.4 at that point.

We aren't likely to make changes which break 3.4 before we also drop 2.7 support:

  • New syntax is obviously problematic (e.g. we've already told folks that async / await redesign efforts are blocked by 2.7 compat).
  • New library stuff likewise (minimal in 3.5, and again blocked by 2.7 compat).

See: https://docs.python.org/3/whatsnew/3.5.html

@crwilcox
Copy link
Contributor Author

@tseaver we are 100% on the same page on this one. If we batch it with 2.7 it will save a major bump and be less disruptive.

@crwilcox crwilcox merged commit 3a9a889 into googleapis:master Mar 20, 2019
atulep pushed a commit that referenced this pull request Apr 3, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
243528a 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
atulep pushed a commit that referenced this pull request Apr 18, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
1628e70 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
f1d7ca2 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
47804c0 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
675c724 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
0ee94ed 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
a042a52 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jul 6, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
e4d8298 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Aug 15, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
6d1e3b9 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
650f406 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
5fa6ea9 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
ebae2c5 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
90fff2f 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
8b1faf1 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
ecad889 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
c4254e0 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
38dde14 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
ff91680 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
5d0719c 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
eb1add8 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
2ac5327 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
489e9e5 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
55f04d5 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
206a85b 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 22, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
dfb34e8 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 31, 2023
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
8e30fb9 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Aug 21, 2025
@crwilcox
Remove classifier for Python 3.4 for end-of-life. (#7535)
5e79782 
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@alixhami alixhami Awaiting requested review from alixhami

@theacodes theacodes Awaiting requested review from theacodes

+1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crwilcox @tseaver @tswast @googlebot