Skip to content

Firestore: fix the example for 'Query.on_snapshot'. #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2019
Merged

Firestore: fix the example for 'Query.on_snapshot'. #7281

merged 1 commit into from
Feb 4, 2019

Conversation

davidair
Copy link
Contributor

@davidair davidair commented Feb 4, 2019

No description provided.

@davidair davidair requested a review from crwilcox as a code owner February 4, 2019 18:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 4, 2019
@tseaver tseaver changed the title Fixing the example of on_snapshot Firestore: fix the example for 'Query.on_snapshot'. Feb 4, 2019
tseaver
tseaver approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches watch.Watch ctor arguments.

@tseaver tseaver added api: firestore Issues related to the Firestore API. type: docs Improvement to the documentation for an API. labels Feb 4, 2019
@tseaver tseaver merged commit 8c988bc into googleapis:master Feb 4, 2019
@tseaver
Copy link
Contributor

tseaver commented Feb 4, 2019

@davidair Thank you for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidair @tseaver @googlebot