Skip to content

fix: respect transform values passed into collection.add #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 11, 2019
Merged

fix: respect transform values passed into collection.add #7072

merged 7 commits into from
Jan 11, 2019

Conversation

mcdonc
Copy link
Contributor

@mcdonc mcdonc commented Jan 9, 2019

closes #6826:

@mcdonc mcdonc requested a review from crwilcox as a code owner January 9, 2019 04:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2019
@mcdonc
Copy link
Contributor Author

mcdonc commented Jan 9, 2019

system test failure appears to be unrelated to this commit (the failing test never takes the codepath that this PR touches)

@tseaver
Copy link
Contributor

tseaver commented Jan 9, 2019

Systest failures due to #7105.

tseaver
tseaver reviewed Jan 9, 2019
View reviewed changes
tseaver
tseaver reviewed Jan 9, 2019
View reviewed changes
@mcdonc mcdonc merged commit 684e88f into googleapis:master Jan 11, 2019
@tseaver tseaver mentioned this pull request Nov 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firestore SERVER_TIMESTAMP only works with "set" and not "add"
4 participants
@mcdonc @tseaver @crwilcox @googlebot