Docs: fix 'CallOptions' examples #6264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove GAX-style 'options', use explicit 'retry' and 'timeout'. Closes #5560. (Other elements of that bug will be fixed in 'gapic-generator' (see: googleapis/gapic-generator#2388) and propagated via autosynth.
|
Merging without review: this is a docs-only fix, where the current samples / docstrings are clearly borked. |
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove GAX 'CallOptions' fossils from README examples. * Fix out-of-date docstring for 'VisionHelpers.annotate_image'. Remove GAX-style 'options', use explicit 'retry' and 'timeout'. Closes #5560. (Other elements of that bug will be fixed in 'gapic-generator' (see: googleapis/gapic-generator#2388) and propagated via autosynth.
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Remove GAX 'CallOptions' fossils from README examples. * Fix out-of-date docstring for 'VisionHelpers.annotate_image'. Remove GAX-style 'options', use explicit 'retry' and 'timeout'. Closes #5560. (Other elements of that bug will be fixed in 'gapic-generator' (see: googleapis/gapic-generator#2388) and propagated via autosynth.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove GAX 'CallOptions' fossils from README examples. * Fix out-of-date docstring for 'VisionHelpers.annotate_image'. Remove GAX-style 'options', use explicit 'retry' and 'timeout'. Closes #5560. (Other elements of that bug will be fixed in 'gapic-generator' (see: googleapis/gapic-generator#2388) and propagated via autosynth.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
* Remove GAX 'CallOptions' fossils from README examples. * Fix out-of-date docstring for 'VisionHelpers.annotate_image'. Remove GAX-style 'options', use explicit 'retry' and 'timeout'. Closes #5560. (Other elements of that bug will be fixed in 'gapic-generator' (see: googleapis/gapic-generator#2388) and propagated via autosynth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In package
README.rstfiles, whereCallOptionswas being shown as a way to trigger paged iteration, usse idiomaticpagesattribute of iteratorsFor
VisionHelper.annotate_image, update docstring to reflect the actual signature, which takesretryandtimeoutrather thanoptions.Closes #5560.
Other elements of that bug will be fixed in
gapic-generatorand propagated via autosynth.