The second concept of the DNS batch #777

mderka · 2016-03-22T22:34:06Z

I added a concept based on our discussion this morning. This is to solicit some feedback.

So far, I created the BatchResult interface in a separate package in DNS, but we said that we would make it part of the core. I will make this happen for the actual PR. I also did not implement all the test, just the integration one to demonstrate the functionality:

DnsBatch batch = DNS.batch();
BatchResult<Page<Zone>, DnsException> batchResult = batch.listZones();
batch.submit();
assertTrue(batchResult.submitted());
Iterator<Zone> iteratorBatch = batchResult.get().iterateAll();

Lastly, the BatchResult interface does not have the notify() method as I am not entirely clear on its meaning. I will add it after some clarifications.

Please, let me know if you like this better and we want to move forward with this concept.

/cc @ajkannan @aozarov @mziccard

coveralls · 2016-03-22T22:40:22Z

Coverage decreased (-0.9%) to 83.615% when pulling a57e043 on mderka:dns-alpha-result into 17442b0 on GoogleCloudPlatform:dns-alpha-batch.

gcloud-java-dns/src/main/java/com/google/gcloud/dns/BatchResultImpl.java

+/**
+ * This class holds a single result of a batch call to the Cloud DNS.
+ */
+public class BatchResultImpl<T> implements BatchResult<T, DnsException> {


🤖 I have created a release *beep* *boop* --- ### [1.3.2](googleapis/java-resourcemanager@v1.3.1...v1.3.2) (2022-05-10) ### Dependencies * update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20220501-1.32.1 ([googleapis#776](googleapis/java-resourcemanager#776)) ([ef17923](googleapis/java-resourcemanager@ef17923)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…der to v2.4.1 (googleapis#777) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-recommender](https://togithub.com/googleapis/java-recommender) | `2.4.0` -> `2.4.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.4.1/compatibility-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-recommender/2.4.1/confidence-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recommender).

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

…-info-reports-plugin to v3.4.0 (#777) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-accessapproval).

🤖 I have created a release *beep* *boop* --- ## [3.5.2](googleapis/java-cloudbuild@v3.5.1...v3.5.2) (2022-08-02) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#777](googleapis/java-cloudbuild#777)) ([35ba1c6](googleapis/java-cloudbuild@35ba1c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.1 (#777) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-container).

…1.3 (googleapis#777) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-websecurityscanner).

Added second concept of DNS batch.

a57e043

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2016

mderka added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: dns Issues related to the Cloud DNS API. labels Mar 22, 2016

aozarov reviewed Mar 23, 2016
View reviewed changes

gcloud-java-dns/src/main/java/com/google/gcloud/dns/BatchResultImpl.java

/**

* This class holds a single result of a batch call to the Cloud DNS.

*/

public class BatchResultImpl<T> implements BatchResult<T, DnsException> {

This comment was marked as spam.

Sign in to view

mderka mentioned this pull request Mar 24, 2016

Third concept of DNS batch. #787

Merged

mderka closed this Apr 6, 2016

suztomo pushed a commit that referenced this pull request Feb 1, 2023

ci: fix downstream check (#777)

b5fd9ab

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

The second concept of the DNS batch #777

The second concept of the DNS batch #777

Uh oh!

mderka commented Mar 22, 2016

Uh oh!

coveralls commented Mar 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

The second concept of the DNS batch #777

The second concept of the DNS batch #777

Uh oh!

Conversation

mderka commented Mar 22, 2016

Uh oh!

coveralls commented Mar 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!