Added integration test for invalid change request. #749

mderka · 2016-03-14T22:39:54Z

Also added checks for the exceptions being non-retryable.
Closes #673.

gcloud-java-dns/src/test/java/com/google/gcloud/dns/it/ITDnsTest.java

+        .build();
+    try {
+      ChangeRequest validChange = ChangeRequest.builder()
+          .add(validA)


ajkannan · 2016-03-15T01:49:49Z

A couple nits, otherwise looks good.

Also added checks for the exceptions being non-retryable. Closes googleapis#673.

Added integration test for invalid change request.

🤖 I have created a release *beep* *boop* --- ## [2.3.1](googleapis/java-accessapproval@v2.3.0...v2.3.1) (2022-06-22) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.0 ([#749](googleapis/java-accessapproval#749)) ([d8646f2](googleapis/java-accessapproval@d8646f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…gleapis#1381) (googleapis#749) * chore: Enable Size-Label bot in all googleapis Java repositories Auto-label T-shirt size indicator should be assigned on every new pull request in all googleapis Java repositories * Remove product Remove product since it is by default true * add license header Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com> Source-Link: googleapis/synthtool@54b2c6a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:fc52b202aa298a50a12c64efd04fea3884d867947effe2fa85382a246c09e813

) * chore: update dependencies for regapic * add more dependencies and trigger comment * update goldens * fix indentation * remove duplicate gax-httpjson dependency * remove duplicated dependencies Source-Link: googleapis/synthtool@fa54eb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.3](googleapis/java-billingbudgets@v2.3.2...v2.3.3) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#749](googleapis/java-billingbudgets#749)) ([a525767](googleapis/java-billingbudgets@a525767)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.5.3](googleapis/java-bigqueryconnection@v2.5.2...v2.5.3) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#748](googleapis/java-bigqueryconnection#748)) ([814c773](googleapis/java-bigqueryconnection@814c773)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…1.4 (#749) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-notification).

* chore: update java template * chore: fix tests * chore: fix tests * chore: update project Source-Link: googleapis/synthtool@1155a97 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:b0b1c1c89570e229b1026372a2b8989ba31495007055b8d30178b7648503eefa

… to v1.42.2 (#749)

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2016

mderka added the api: dns Issues related to the Cloud DNS API. label Mar 14, 2016

mderka force-pushed the spi-refactor branch from 61a44c9 to 34a4468 Compare March 14, 2016 22:43

ajkannan reviewed Mar 15, 2016
View reviewed changes

gcloud-java-dns/src/test/java/com/google/gcloud/dns/it/ITDnsTest.java

.build();

try {

ChangeRequest validChange = ChangeRequest.builder()

.add(validA)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

mderka force-pushed the spi-refactor branch from 34a4468 to 6dac63f Compare March 15, 2016 16:13

Added integration test for invalid change request.

baee7d7

Also added checks for the exceptions being non-retryable. Closes googleapis#673.

mderka force-pushed the spi-refactor branch from 6dac63f to baee7d7 Compare March 15, 2016 17:19

mderka added a commit that referenced this pull request Mar 15, 2016

Merge pull request #749 from mderka/spi-refactor

736b6e1

Added integration test for invalid change request.

mderka merged commit 736b6e1 into googleapis:dns-alpha Mar 15, 2016

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency com.google.http-client:google-http-client-bom…

68a82f4

… to v1.42.2 (#749)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added integration test for invalid change request. #749

Added integration test for invalid change request. #749

Uh oh!

mderka commented Mar 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Mar 15, 2016

Uh oh!

Uh oh!

Added integration test for invalid change request. #749

Added integration test for invalid change request. #749

Uh oh!

Conversation

mderka commented Mar 14, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ajkannan commented Mar 15, 2016

Uh oh!

Uh oh!