fix(pubsub): Make retry policy back off more aggressively for RPCs that retry RESOURCE_EXHAUSTD #8438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RESOURCE_EXHAUSTD PiperOrigin-RevId: 557935020 Source-Link: googleapis/googleapis@38e1f31 Source-Link: googleapis/googleapis-gen@5bbe39d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWJiZTM5ZDM3MjE4YTQyMGIyMzY4YzM3NTQxZGU1ODg3ZGI3ZDZhZiJ9
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
quartzmo
approved these changes
Aug 18, 2023
+ pushd policytroubleshooter
+ runPresubmitTests
+ [[ /tmpfs/src/google-cloud-go/policytroubleshooter == *\/\i\n\t\e\r\n\a\l\/* ]]
+ [[ /tmpfs/src/google-cloud-go/policytroubleshooter == *\/\t\h\i\r\d\_\p\a\r\t\y\/* ]]
+ '[' -z ']'
/tmpfs/src/google-cloud-go/policytroubleshooter /tmpfs/src/google-cloud-go
+ go test -race -v -timeout 15m -short ./...
+ tee sponge_log.log
go: downloading cloud.google.com/go/iam v1.1.0
/go/pkg/mod/cloud.google.com/go/iam@v1.1.0/apiv2/iampb/policy.pb.go:28:2: missing go.sum entry for module providing package cloud.google.com/go/longrunning/autogen/longrunningpb (imported by cloud.google.com/go/iam/apiv2/iampb); to add:
go get cloud.google.com/go/iam/apiv2/iampb@v1.1.0
+ '[' -f emulator_test.sh ']'
+ cat sponge_log.log
+ go-junit-report -set-exit-code
+ exit_code=0
+ [[ /tmpfs/src/google-cloud-go/policytroubleshooter != *\/\i\n\t\e\r\n\a\l\/* ]]
+ go build ./...
/go/pkg/mod/cloud.google.com/go/iam@v1.1.0/apiv2/iampb/policy.pb.go:28:2: missing go.sum entry for module providing package cloud.google.com/go/longrunning/autogen/longrunningpb (imported by cloud.google.com/go/iam/apiv2/iampb); to add:
go get cloud.google.com/go/iam/apiv2/iampb@v1.1.0
/tmpfs/src/google-cloud-go
+ exit_code=1 |
=== RUN TestClient_CustomRetry
pubsub_test.go:58: got: &{{100000000 60000000000 4 0} [10 1 13 8 2 14 4]}, want: &{{100000000 60000000000 1.3 0} [10 1 13 8 2 14 4]}
--- FAIL: TestClient_CustomRetry (0.03s) |
quartzmo
added a commit
to quartzmo/google-cloud-go
that referenced
this pull request
Aug 18, 2023
sources were generated in googleapis#8436,googleapis#8438
quartzmo
added a commit
that referenced
this pull request
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 557935020
Source-Link: googleapis/googleapis@38e1f31
Source-Link: https://github.com/googleapis/googleapis-gen/commit/5bbe39d37218a420b2368c37541de5887db7d6af
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNWJiZTM5ZDM3MjE4YTQyMGIyMzY4YzM3NTQxZGU1ODg3ZGI3ZDZhZiJ9