Skip to content

fix(firestore): return error from NewClient if projectID is not set #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2021
Merged

fix(firestore): return error from NewClient if projectID is not set #4299

merged 2 commits into from
Jun 24, 2021

Conversation

Gregory-Ledray
Copy link
Contributor

To fix #4298

@Gregory-Ledray Gregory-Ledray requested review from crwilcox, tritone and a team as code owners June 22, 2021 20:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
@Gregory-Ledray
Copy link
Contributor Author

Feel free to abandon this PR.

@codyoss codyoss changed the title Return error from NewClient if projectID is not set fix(firestore): return error from NewClient if projectID is not set Jun 22, 2021
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Jun 23, 2021
@crwilcox crwilcox added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 23, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 23, 2021
@crwilcox crwilcox merged commit 1e1f4e2 into googleapis:master Jun 24, 2021
@hongalex hongalex mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone Awaiting requested review from tritone

1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firestore: Unclear Error when Project ID is not set
3 participants
@Gregory-Ledray @crwilcox @kokoro-team