fix(token-usage): fix token usage recording for failed API calls #7667
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @nsalerni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves an issue where the system was incorrectly logging token usage for API calls that failed. The change ensures that token usage metrics are only recorded when an API call is successful, providing more accurate reporting and preventing misleading data for users, particularly those using Google OAuth.
Highlights
- Accurate Token Usage Logging: Corrected an issue where token usage was recorded for failed API calls, leading to inaccurate metrics. The logging mechanism now only records usage for successful API responses.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where token usage was recorded for failed streaming API calls by moving the success logging logic into the try block. My review includes a suggestion to further improve the logic to ensure that successful API calls that return an empty stream are also logged for complete telemetry, which seems to be a pre-existing issue but is relevant to the changed code.
|
@cornmander @bdmorgan are either of you able to help merge this? |
|
@nsalerni queued to merge - thanks!! |
…gle-gemini#7667) Co-authored-by: Bryan Morgan <bryanmorgan@google.com>
…gle-gemini#7667) Co-authored-by: Bryan Morgan <bryanmorgan@google.com>
TLDR
Fixes issue where Google OAuth users saw incorrect token usage for failed API
calls. This was tested using the gemini-2.5-flash-image-preview model which does
not work in gemini-cli, however, it still reported token usage despite the API
error.
This PR fixes this by recording token usage metrics for successful API calls,
not failed ones.
Reviewer Test Plan
Testing Matrix
Linked issues / bugs
Resolves #7598