-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add gemini extensions link
command
#7241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new link
command to the gemini extensions
CLI, providing a mechanism similar to npm link
. This allows users to install extensions by creating a symbolic link to a local development directory. The primary benefit is enabling real-time reflection of changes made in the local extension source, significantly streamlining the development and testing workflow for extensions. The changes involve adding the new command, updating the extension management system to support this new 'link' type, and adjusting the update process for linked extensions.
Highlights
- New
gemini extensions link
command: A newlink
command has been introduced undergemini extensions
, enabling developers to install extensions by creating a symbolic link to a local directory. - Enhanced Extension Management: The core extension loading and installation logic has been updated to recognize and properly handle 'linked' extensions, ensuring that changes in the source directory are immediately reflected without reinstallation.
- Improved Update Mechanism for Linked Extensions: The
updateExtension
command now includes specific logic for linked extensions, allowing them to be 'updated' by simply reloading their configuration, avoiding unnecessary file operations. - New Test Coverage: Comprehensive test cases have been added to validate the correct loading and installation behavior of linked extensions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a link
command for extensions, which is a useful feature for local development. The implementation correctly modifies installExtension
, loadExtension
, and updateExtension
to handle this new 'linked' extension type. I've identified a few areas for improvement regarding input validation, error logging, and the user experience for the update command when an extension is already up-to-date. My detailed feedback is in the comments below.
Code Coverage Summary
CLI Package - Full Text Report
Core Package - Full Text Report
For detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TLDR
Add a
link
command similar to npm link for installing an extension with a symlink to a local directory.This allows the extension to reflect the latest updates without any add'l effort.
This is useful if e.g., an enterprise wants to provide a suite of extensions for users, or if someone is testing an extension they are developing locally.
Dive Deeper
We could have this as a flag on the install command instead
Reviewer Test Plan
Testing Matrix
Linked issues / bugs