Skip to content

Conversation

kuanyili
Copy link

@kuanyili kuanyili commented Mar 20, 2024

Strip interpolation to prevent the font list from being unexpectedly merged into one single string element.

When we have these SCSS variables set in assets/scss/_variables_project.scss

$td-google-font-name: "Noto Sans", "Noto Sans TC";
$td-google-font-family: "Noto+Sans:300,300i,400,400i,700,700i|Noto+Sans+TC:300,400,700";

Before the patch, we have this in our generated main.css

font-family: "Noto Sans, Noto Sans TC", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";

and this after the patch

font-family: "Noto Sans", "Noto Sans TC", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";

References

@kuanyili kuanyili force-pushed the multiple-google-fonts branch from 1b62691 to 179bc30 Compare April 29, 2024 22:56
@kuanyili kuanyili force-pushed the multiple-google-fonts branch from 179bc30 to 6b0d4d8 Compare August 10, 2024 01:04
Strip interpolation to prevent the font list from being unexpectedly
merged into one single string element.
@kuanyili kuanyili force-pushed the multiple-google-fonts branch from 6b0d4d8 to 6c9af0a Compare July 6, 2025 12:59
@kuanyili kuanyili changed the title Support multiple fonts from Google Support loading multiple fonts from Google Fonts Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant