do not pull in tensorboard's keras callback #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andsteing would you be able to help me with reviewing the change? thanks! |
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…#336 PiperOrigin-RevId: 617332775
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…#336 PiperOrigin-RevId: 617332775
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
…#336 PiperOrigin-RevId: 617332775
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
…#336 PiperOrigin-RevId: 617332775
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
…#336 PiperOrigin-RevId: 617332775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i am moving some of my models to keras3 and using jax backend for training. i am on a slightly older tensorboard (2.12) so when it pulls in keras callback through
from tensorboard.plugins.hparams import apiit tries to pull in keras2 sinceapialso import keras callback in tensorboard repo.this pr basically adjusted import to avoid accidentally pulling in keras in clu.