Skip to content

Use numbered capture groups for sentry-trace validation #4652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2025
Merged

Use numbered capture groups for sentry-trace validation #4652

merged 5 commits into from
Aug 25, 2025

Conversation

alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Aug 25, 2025 •
edited by markushi
Loading

📜 Description

As named capturing groups are not supported on older Android versions (<8.0 / <API level 26)

Closes #4651

💡 Motivation and Context

Only starting with API level 26 are named capture groups supported, whereas our minSdk is set to 21.

💚 How did you test it?

In Android Studio:

  • The old version generated red-underlined syntax errors.
  • The new version does not.

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 25, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 407.02 ms 482.76 ms 75.74 ms
Size 1.58 MiB 2.10 MiB 530.95 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ee747ae 386.94 ms 431.43 ms 44.49 ms
ee747ae 405.43 ms 485.70 ms 80.28 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ee747ae 382.73 ms 435.41 ms 52.68 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms

App size

Revision Plain With Sentry Diff
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: webb/use-numbered-capture-groups-for-sentry-trace-header-validation

Startup times

Revision Plain With Sentry Diff
51f57f8 419.54 ms 470.84 ms 51.30 ms
765567d 378.67 ms 430.08 ms 51.41 ms

App size

Revision Plain With Sentry Diff
51f57f8 1.58 MiB 2.10 MiB 530.95 KiB
765567d 1.58 MiB 2.10 MiB 530.95 KiB

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review August 25, 2025 06:28
adinauer
adinauer approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for fixing

@adinauer adinauer merged commit b8ab780 into main Aug 25, 2025
44 of 48 checks passed
@adinauer adinauer deleted the webb/use-numbered-capture-groups-for-sentry-trace-header-validation branch August 25, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@adinauer adinauer adinauer approved these changes

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8.19+ lost compatibility with API older than 26?
4 participants
@alexander-alderman-webb @markushi @adinauer @lcian