Skip to content

ref(analytics): some more Event class/record call conversions #98889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref(analytics): some more Event class/record call conversions #98889

wants to merge 1 commit into from
+275 −216

Conversation

constantinius
Copy link
Contributor

@constantinius constantinius requested review from a team as code owners September 5, 2025 08:16
@linear Linear
Copy link

linear bot commented Sep 5, 2025

TET-1114 Analytics: last remnants of Event conversion

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 5, 2025
@constantinius constantinius requested a review from a team September 5, 2025 08:17
@constantinius constantinius mentioned this pull request Sep 5, 2025
Draft
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

❌ 17 Tests Failed:

Tests completed Failed Passed Skipped
27577 17 27560 597
View the top 3 failed test(s) by shortest run time 
tests.sentry.autofix.test_webhooks.AutofixPrWebhookTest::test_opened
Stack Traces | 1.11s run time 
#x1B[1m#x1B[.../sentry/autofix/test_webhooks.py#x1B[0m:54: in test_opened
    assert_last_analytics_event(
#x1B[1m#x1B[.../testutils/helpers/analytics.py#x1B[0m:58: in assert_last_analytics_event
    assert_event_equal(
#x1B[1m#x1B[.../testutils/helpers/analytics.py#x1B[0m:17: in assert_event_equal
    raise AssertionError(
#x1B[1m#x1B[31mE   AssertionError: Expected event type <class 'sentry.analytics.events.ai_autofix_pr_events.AiAutofixPrOpenedEvent'> but got <class 'str'>#x1B[0m
tests.sentry.autofix.test_webhooks.AutofixPrWebhookTest::test_merged
Stack Traces | 1.16s run time 
#x1B[1m#x1B[.../sentry/autofix/test_webhooks.py#x1B[0m:137: in test_merged
    assert_last_analytics_event(
#x1B[1m#x1B[.../testutils/helpers/analytics.py#x1B[0m:58: in assert_last_analytics_event
    assert_event_equal(
#x1B[1m#x1B[.../testutils/helpers/analytics.py#x1B[0m:17: in assert_event_equal
    raise AssertionError(
#x1B[1m#x1B[31mE   AssertionError: Expected event type <class 'sentry.analytics.events.ai_autofix_pr_events.AiAutofixPrMergedEvent'> but got <class 'str'>#x1B[0m
tests.sentry.autofix.test_webhooks.AutofixPrWebhookTest::test_closed
Stack Traces | 1.23s run time 
#x1B[1m#x1B[.../sentry/autofix/test_webhooks.py#x1B[0m:96: in test_closed
    assert_last_analytics_event(
#x1B[1m#x1B[.../testutils/helpers/analytics.py#x1B[0m:58: in assert_last_analytics_event
    assert_event_equal(
#x1B[1m#x1B[.../testutils/helpers/analytics.py#x1B[0m:17: in assert_event_equal
    raise AssertionError(
#x1B[1m#x1B[31mE   AssertionError: Expected event type <class 'sentry.analytics.events.ai_autofix_pr_events.AiAutofixPrClosedEvent'> but got <class 'str'>#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@constantinius