feat(checkout v3): Cart diff #98394
Merged
feat(checkout v3): Cart diff #98394
+772
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-54
to
-57
| /** | ||
| * TODO(isabella): Add this back in (was not ported from checkout v1 to v2) | ||
| */ | ||
| discountInfo?: Promotion['discountInfo']; |
There was a problem hiding this comment.
We don't use these anymore (parent component never passes in discountInfo)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98394 +/- ##
==========================================
- Coverage 81.18% 80.60% -0.59%
==========================================
Files 8546 8590 +44
Lines 376654 376637 -17
Branches 23961 24566 +605
==========================================
- Hits 305793 303589 -2204
- Misses 70496 72679 +2183
- Partials 365 369 +4 |
There was a problem hiding this comment.
tiny styling changes i was bothered sorry
There was a problem hiding this comment.
minor styling change
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
scttcper
approved these changes
Sep 2, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/BIL-1214/update-cart-styling-and-information
cart.diff.mov