Skip to content

Delete unused web_unicode library #174896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Delete unused web_unicode library #174896

wants to merge 6 commits into from
+1 −5,546

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Sep 3, 2025 •
edited
Loading

The web_unicode library was used by the HTML renderer which doesn't exist anymore.

Depends on #174967

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Sep 3, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the unused web_unicode library. The changes are straightforward, deleting references to the library from build configurations, dependency lists, and tests. This is a good cleanup of obsolete code.

eyebrowsoffire
eyebrowsoffire approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

harryterkelsen
harryterkelsen approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar mentioned this pull request Sep 4, 2025
Merged
@mdebbar mdebbar mentioned this pull request Sep 4, 2025
Closed
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2025
@mdebbar
Remove 'terms of use' wording from web_unicode (#174939)
31aaf38 
This library isn't used anywhere and will be deleted here:
#174896

I'm removing the "terms of use" wording to unblock the G3 roll while I
investigate the failures on the full deletion PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingjun chingjun chingjun approved these changes

@harryterkelsen harryterkelsen harryterkelsen approved these changes

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
engine flutter/engine related. See also e: labels. platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdebbar @chingjun @harryterkelsen @eyebrowsoffire