refactor: remove TLS from vcpus #5428
Open
+156
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2471eea to
334c095
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5428 +/- ##
==========================================
- Coverage 82.73% 82.73% -0.01%
==========================================
Files 263 263
Lines 27455 27455
==========================================
- Hits 22715 22714 -1
- Misses 4740 4741 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
334c095 to
f719453
Compare
Instead of storing mmaped kvm_vcpu struct in the TLS, we can have it in the VcpuHandle. This way we don't need to deal with TLS and it's synchronization. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Since we store VcpuFds in VcpuHandles inside Vmm, and GDB stub has access to Vmm, remove redundant duplication of VcpuFds. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
f719453 to
5d27e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of storing mmaped kvm_vcpu struct in the TLS, we can have it in the VcpuHandle. This way we don't need to deal with TLS and it's synchronization.
Reason
Dealing with TLS was difficult and bug prone
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.