Skip to content

fix(auth, ios): fix the parsing of an error that could specifically happen when using MicrosoftProvider #12920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix(auth, ios): fix the parsing of an error that could specifically happen when using MicrosoftProvider #12920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/firebase_auth/firebase_auth/ios/Classes/FLTFirebaseAuthPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,24 @@ static void handleAppleAuthResult(FLTFirebaseAuthPlugin *object, AuthPigeonFireb
underlyingError.userInfo[@"FIRAuthErrorUserInfoDes"
@"erializedResponseKey"];

if (firebaseDictionary != nil && firebaseDictionary[@"message"] != nil) {
if (firebaseDictionary == nil &&
userInfo[@"FIRAuthErrorUserInfoNameKey"] != nil) {
// Removing since it's not parsed and causing issue when sending back the
// object to Flutter
NSMutableDictionary *mutableUserInfo = [userInfo mutableCopy];
[mutableUserInfo
removeObjectForKey:@"FIRAuthErrorUserInfoUpdatedCredentialKey"];
NSError *modifiedError = [NSError errorWithDomain:error.domain
code:error.code
userInfo:mutableUserInfo];

completion(nil,
[FlutterError errorWithCode:@"sign-in-failed"
message:userInfo[@"NSLocalizedDescription"]
details:modifiedError.userInfo]);

} else if (firebaseDictionary != nil &&
firebaseDictionary[@"message"] != nil) {
// error from firebase-ios-sdk is
// buried in underlying error.
completion(nil,
Expand Down