add translation and rotation offsets to RenderAssetCreationInfo #2574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously when creating RenderAssetInstances we've assumed the top level transformation (object's state pose) is enough and that other local transformations will be encapsulated within the asset or the owning superstructure (e.g. the articulated rig). However, when using RenderReplay in HitL with isaac integration we run replay at the link level rather than the visual shape level. Since URDF visual shapes can support their own local transformation frame () we were missing a few local transformations leading to a mismatch between the Isaac internal simulation state and the render state seen in the client.
This change introduces an additional level of configurable local transformations to the render instance pipeline allowing these per-visual element offsets to be properly captured. In general this change allows local transformation offsets to be defined and tracked by RenderReplay.
How Has This Been Tested
Tested locally in HitL.
TODO: unit tests.
Types of changes
Checklist