Skip to content

[WIP] test updating python version to 3.10 #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] test updating python version to 3.10 #2568

wants to merge 1 commit into from

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Apr 22, 2025

Motivation and Context

python 3.9 is no longer supported. This PR checks the consequences of upgrading to 3.10.

How Has This Been Tested

CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 22, 2025
KAVYANSHTYAGI
KAVYANSHTYAGI reviewed May 5, 2025
View reviewed changes
Copy link

@KAVYANSHTYAGI KAVYANSHTYAGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Python 3.10 tested across all OSes (Linux/macOS/Windows)?
Any dependency incompatibilities surfaced?

Suggestions:
Add 3.10 to README Installation Instructions:

Add a short note like:
"Python 3.10 is the new minimum version. Please ensure your environment matches."

Deprecation Note:

In CHANGELOG: mark Python 3.9 as deprecated and removed.

Backward Compatibility:

If Python 3.9 users are still common, clarify that support has officially dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@KAVYANSHTYAGI KAVYANSHTYAGI KAVYANSHTYAGI left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @KAVYANSHTYAGI @facebook-github-bot