Skip to content

Conversation

danieltmeta
Copy link

This PR is to update the installation instructions for the doc folder for html documentation reference.

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This PR is to update the installation instructions for the doc folder for html documentation reference.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 21, 2024
@0mdc 0mdc requested review from aclegg3 and 0mdc June 21, 2024 02:20
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating with your experience. Some thoughts/comments before we change the docs.

@@ -27,10 +34,14 @@ export PATH=$PATH:/Library/TeX/Distributions/.DefaultTeX/Contents/Programs/texbi

### Building Docs:
```bash
python setup.py build_ext --inplace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this not work for you? I think this worked for me last time.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't work for me, for some reason I had to go to the root and run ./build.sh, then go back down to the docs folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I agree you can do the source build this way to get a similar result, but the inplace build should do it and worked for me in the past.

./build.sh # or ./build-public.sh when deploying to aihabitat.org

cd habitat-sim
./build.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need --with-bullet to compile the physics libraries in order for their docstrings to be available after building the docs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might be it. My method somehow make the "magnum" part load, maybe that was the physics libraries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magnum will load either way, but some parts of the code are compiled out when bullet isn't included.

danieltmeta and others added 2 commits June 21, 2024 15:36
Co-authored-by: Alexander Clegg <alexanderwclegg@gmail.com>
@danieltmeta danieltmeta requested a review from aclegg3 June 21, 2024 23:03
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments!

```

To build the docs, you will also need to install the following
packages on Linux :
To build the docs, you will also need to install textlive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: texlive

```bash
python setup.py build_ext --inplace
cd docs
git submodule update --init
./build.sh # or ./build-public.sh when deploying to aihabitat.org
```

For Fedora:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The steps should be the same for Ubuntu and Fedora.

@facebook-github-bot
Copy link
Contributor

Hi @danieltmeta!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants