chore(ci): Change Lighthouse trigger from pull_request_target to pull_request #11393
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The recent Nx critical supply chain attack (https://socket.dev/blog/nx-packages-compromised) is due to the usage of
pull_request_target: https://x.com/adnanthekhan/status/1958722939534417989We also use
pull_request_targeton this action, but:So, I'm moving the event to the much safer
pull_request. This:Posting a comment to an external PR should be fixable. If someone wants to improve our workflow, please submit a PR, but I'll only accept the usage of
pull_request_targeton tiny workflows that doesn't execute any code outside of the Yaml workflow itself.See also https://github.blog/security/application-security/how-to-secure-your-github-actions-workflows-with-codeql/
Test Plan
CI