Skip to content

Conversation

swoboda1337
Copy link
Member

@swoboda1337 swoboda1337 commented Sep 3, 2025

What does this implement/fix?

ESP8266 and Libretiny had basically identical software implementations, create a single software version.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • nRF52840

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

github-actions bot commented Sep 3, 2025

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#10548
    components: [remote_receiver, remote_transmitter]
    refresh: 1h

(Added by the PR bot)

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.54%. Comparing base (4d681ff) to head (8ada874).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10548   +/-   ##
=======================================
  Coverage   60.54%   60.54%           
=======================================
  Files          51       51           
  Lines       10444    10444           
  Branches     1391     1391           
=======================================
  Hits         6323     6323           
  Misses       3762     3762           
  Partials      359      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swoboda1337 swoboda1337 changed the title [remote] Remove duplicate implementations of remote receiver and remote transmitter [remote] Remove duplicate implementations of remote code Sep 3, 2025
@swoboda1337 swoboda1337 marked this pull request as ready for review September 3, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants