Skip to content

fix: support option to override publish trigger (--policy) in publish command #9228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2025
Merged

fix: support option to override publish trigger (--policy) in publish command #9228

merged 2 commits into from
Aug 5, 2025

Conversation

choegyumin
Copy link
Contributor

@choegyumin choegyumin commented Jul 31, 2025 •
edited
Loading

Related:

Add support for overriding the policy option in the 'publish' command, like the 'build' command:

# 'build' command (pack & publish)
electron-builder --publish always

# 'publish' command (only publish)
electron-builder publish --policy always

This change is necessary to override the intended behavior in the CI environment (See the following code):

electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts

Lines 87 to 94 in cf0ac45

const tag = getCiTag()
if (tag != null) {
log.info({ reason: "tag is defined", tag }, "artifacts will be published")
publishOptions.publish = "onTag"
} else if (isCi) {
log.info({ reason: "CI detected" }, "artifacts will be published if draft release exists")
publishOptions.publish = "onTagOrDraft"
}

Currently, the 'publish' command(CLI) has a problem where it cannot read the configuration file path. The following PR resolves issue:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: ee248cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@choegyumin choegyumin marked this pull request as ready for review July 31, 2025 10:13
@choegyumin choegyumin mentioned this pull request Jul 31, 2025
Closed
@choegyumin choegyumin changed the title fix: support option to override PublishPolicy in publish command fix: support option to override publish trigger (--policy) in publish command Jul 31, 2025
mmaietta
mmaietta previously approved these changes Jul 31, 2025
View reviewed changes
@mmaietta mmaietta merged commit d031eea into electron-userland:master Aug 5, 2025
49 of 53 checks passed
This was referenced Aug 1, 2025
Merged
Open
Open
Closed
Open
This was referenced Aug 10, 2025
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Aug 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaietta mmaietta mmaietta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@choegyumin @mmaietta