fix(mac): only fuse macOS universal builds on the combined universal package #8799
Conversation
…package Without this `@electron/universal` would error complaining that the x64 and the arm64 builds varied in an unexpected place. Could have maybe overridden `addElectronFuses` in MacPackager, but we didn't have a reference to the fact we were building a universal package from the param in `doPack` and didn't want to explore adding more properties in the area. Fixes electron-userland#8798
🦋 Changeset detectedLatest commit: e94457f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Running tests locally proved a pain:
|
|
Very elegant of a fix, thank you! The number of args being passed to |
Sure thing |
|
@mmaietta sorry to confirm, are you going to push those changes to my branch or would you like me to do them? Happy either way, if the latter then please just clarify if you expect all the params to be wrapped up in a Context-like struct or just the boolean flags |
|
No actions needed from your side. I should be able to push to this PR directly using |
1c8f733 to
e94457f
Compare
Without this
@electron/universalwould error complaining that the x64 and the arm64 builds varied in an unexpected place. Could have maybe overriddenaddElectronFusesin MacPackager, but we didn't have a reference to the fact we were building a universal package from the param indoPackand didn't want to explore adding more properties in the area.Fixes #8798