Update network interfaces periodically #2004
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'dependencies', 'enhancement', 'bug', 'breaking-change', 'internal', 'new feature', 'documentation'} |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2004 +/- ##
==========================================
- Coverage 71.05% 70.97% -0.09%
==========================================
Files 367 367
Lines 61867 61890 +23
==========================================
- Hits 43961 43927 -34
- Misses 17906 17963 +57 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
40c5dd7 to
f7b0c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #1706
I did try to make it configurable, but it failed with a recursive dependency issue between the modules.
This is not the proper solution but I believe that is a better approach than the original concept of never updating.