Skip to content

Fixes for dolt_tests #9753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 29, 2025
Merged

Fixes for dolt_tests #9753

merged 5 commits into from
Aug 29, 2025

Conversation

NathanGabrielson
Copy link
Contributor

@NathanGabrielson NathanGabrielson commented Aug 29, 2025 •
edited
Loading

Couple of fixes for dolt_tests:

  1. Allow comparison of int64 values, which enables running aggregate queries like sum and avg, for instance.
  2. Can check if values are/are not null
  3. Fixed a bug where NULL test_group_name values would break the function.

@coffeegoddd
Copy link
Contributor

@NathanGabrielson DOLT

comparing_percentages
100.000000 to 100.000000
version result total
25c8247 ok 5937471
version total_tests
25c8247 5937471
correctness_percentage
100.0

@NathanGabrielson NathanGabrielson marked this pull request as ready for review August 29, 2025 21:03
macneale4
macneale4 requested changes Aug 29, 2025
View reviewed changes
macneale4
macneale4 approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT!


--    .-""-.
   ) (     )
  (   )   (
     /     )
    (_    _)                     0_,-.__
      (_  )_                     |_.-._/
       (    )                    |_--..\
        (__)                     |__--_/
     |''   ``\                   |
     |        \                  |      /b.
     |         \  ,,,---===?A`\  |  ,==y'
   ___,,,,,---==""\        |M] \ | ;|\ |>
           _   _   \   ___,|H,,---==""""bno,
    o  O  (_) (_)   \ /          _     AWAW/
                     /         _(+)_  dMM/
      \@_,,,,,,---=="   \      \\|//  MW/
--''''"                         ===  d/
                                    //
                                    ,'__________________________
   \    \    \     \               ,/~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         _____    ,'  ~~~   .-""-.~~~~~~  .-""-.
      .-""-.           ///==---   /`-._ ..-'      -.__..-'
            `-.__..-' =====\\\\\\ V/  .---\.
 PGMG                 ~~~~~~~~~~~~, _',--/_.\  .-""-.
                            .-""-.___` --  \|         -.__..-

@NathanGabrielson NathanGabrielson merged commit 4c23057 into main Aug 29, 2025
23 of 24 checks passed
@coffeegoddd
Copy link
Contributor

@NathanGabrielson DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7b676b8 ok 5937471
version total_tests
7b676b8 5937471
correctness_percentage
100.0

@BrewTestBot BrewTestBot mentioned this pull request Sep 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macneale4 macneale4 macneale4 approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NathanGabrielson @coffeegoddd @macneale4