Fix and improve conditional modifier #2653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more complicated then I had hoped but I guess it's necessary. It introduces a parse-stack that contains all parsing methods. This allows modifiers to be injected into different points of the stack, not all at once. Now the conditional modifier can correctly run before variables, while the autopause modifier can correctly run after the variables. This should also provide more flexibility later on if we need to have better control over other parsing order. Compatibility breaking: This changes the signature of the Text.parse_text() method, removing all the individual flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more complicated then I had hoped but I guess it's necessary. It introduces a parse-stack that contains all parsing methods. This allows modifiers to be injected into different points of the stack, not all at once. Now the conditional modifier can correctly run before variables, while the autopause modifier can correctly run after the variables.
This should also provide more flexibility later on if we need to have better control over other parsing order.
Compatibility breaking: This changes the signature of the Text.parse_text() method, removing all the individual flags.