Check URI is relative before processing as relative #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
approved these changes
Jul 16, 2022
f316838 to
2dea84d
Compare
smeddows
reviewed
Jan 16, 2024
| @@ -42,8 +42,16 @@ public bool TryParseMessage(in ReadOnlySequence<byte> input, ref SequencePositio | |||
| return false; | |||
| } | |||
|
|
|||
| //First char must be / for relative URI | |||
| if (path[0] == (byte)'/') | |||
There was a problem hiding this comment.
I know this is old. But @adamradocz , won't the compiler just have this as a literal? No need to cache something that isn't an instance, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http1RequestMessageReader makes an assumption that the path provided is a relative path when constructing a Uri(). This causes an exception when parsing a CONNECT message, and presumably when the path is fully qualified.