Fixes #174: Compatibility with older Git versions. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've confirmed that this works with both Git 2.1.4 and Git 2.14.1, the oldest and newest releases that you'll typically see in the wild. @cweagans if this looks good to you and you can merge it, I'll try to test the dev branch in more places, and then maybe we can tag a new release |
|
@cweagans @danepowell One should check github issues first, then debug issues oneself ;) Read: Tested it right now and it works fine! |
|
Thanks, this fixed the issue for me with git version 2.7.4. under the covers it's falling back to the patch command with this change |
|
Sorry for the slowness here folks. This all looks great. Will tag a release. |
lhridley
pushed a commit
to promet/composer-patches
that referenced
this pull request
Apr 6, 2018
Fixes cweagans#174: Compatibility with older Git versions. Modifying source to promet/composer-patches, adding a var_dump(); die
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still testing this locally but wanted to get this out so we could start review.
The first commit is the only functional change: adding a conditional to only use
git applyon git repos.The second commit is a refactor to encapsulate this functionality and make it a little cleaner to edit in the future.