socks: parameterise connection filter #17417
Closed
+87
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
Jun 20, 2025
b54457d to
84d4564
Compare
Pass the config values that a SOCKS connection filter needs when creating the filter: remote host/port and credentials. Move the logic of finding out where a SOCKS filter should tunnel into `connect.c` where the filter is created. This keeps the interpretation of the various connection bits in less places in the source and could allow to chain SOCKS filters in future scenarios.
d611c3d to
c8eccf0
Compare
|
abandoning this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the config values that a SOCKS connection filter needs when creating the filter: remote host/port and credentials.
Move the logic of finding out where a SOCKS filter should tunnel into
connect.cwhere the filter is created.This keeps the interpretation of the various connection bits in less places in the source and could allow to chain SOCKS filters in future scenarios.