Fix shadowed iterator variable in GaussLegendreXW #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The for loop in GaussLegendreXW initializes an iterator variable `it` that shadows a previously declared `it` outside the loop. The outer `it` is compared to `MAXIT`, but because it's shadowed it's never updated, so the panic will never be triggered if it did not converge.
|
Hi, thanks for the fix. Testing this case it's tricky because we need to find a failing problem. But don't worry, I'll work on this in the upcoming weeks. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The for loop in GaussLegendreXW initializes an iterator variable
itthat shadows a previously declareditoutside the loop. The outeritis compared toMAXIT, but because it's shadowed it's never updated, so the panic will never be triggered if it did not converge.A linter surfaced this issue for me. I don't know how to test it, though...