Skip to content

Conversation

exigow
Copy link
Collaborator

@exigow exigow commented Sep 5, 2025

It's resolving one of problems during plugin verification. I manually tested this feature to make sure there are no regressions.

Solves:
Override-only method AddLicenseKey.actionPerformed(AnActionEvent) is invoked in AddLicenseKey.createErrorAction$1.invoke(...). This method is marked with @ApiStatus.OverrideOnly annotation, which indicates that the method must be only overridden but not invoked by client code. See documentation of the @ApiStatus.OverrideOnly for more info.

Extra: minor fixes (deprecated methods removal/attempts).


Summary by cubic

Fixes IntelliJ Plugin Verifier error by removing direct calls to the override-only AddLicenseKey.actionPerformed and moving logic into a reusable method. No behavior changes.

  • Bug Fixes

    • Extracted performAddLicenseKey(project) and used it for both the action and the “Try again” notification.
    • Ensures a non-null project before showing the dialog and sending the request.
  • Refactors

    • Replaced deprecated HorizontalAlign.FILL with AlignX.FILL in the dialog.
    • Added TODO to migrate from IdeaReportingEvent to IdeaLoggingEvent in error submitter.

@exigow exigow requested a review from a team as a code owner September 5, 2025 15:28
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 5, 2025
Copy link

github-actions bot commented Sep 5, 2025

⚠️ AI review completed but no review output was generated. Check the action logs for details.


💡 To request a new review, comment @continue-general-review

It's resolving one of problems during plugin verification. I manually tested this feature to make sure there are no regressions.

Solves error:
Override-only method AddLicenseKey.actionPerformed(AnActionEvent) is invoked in AddLicenseKey.createErrorAction$1.invoke(...). This method is marked with @ApiStatus.OverrideOnly annotation, which indicates that the method must be only overridden but not invoked by client code. See documentation of the @ApiStatus.OverrideOnly for more info.
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 5, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 18ec563 into main Sep 5, 2025
86 of 90 checks passed
@Patrick-Erichsen Patrick-Erichsen deleted the exigow/dont-use-action-performed branch September 5, 2025 19:36
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants