Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Sep 4, 2025

Description

Fixes the the AbortError2 which appears when streaming fim.

This was happening due to GeneratorReuseManager. It was mostly happening during initial autocomplete requests and backspace or prefix mismatch.

resolves CON-3730

closes #7246

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixes AbortError2 during FIM streaming so aborted autocomplete requests are treated as cancels, not errors, preventing spurious failures on initial requests and backspace/prefix mismatches. Resolves CON-3730; closes #7246.

  • Bug Fixes
    • Updated BaseLLM to log success only when no error; aborts now detected via error.name includes "AbortError" and logged as cancel, otherwise as error.
    • Prevents GeneratorReuseManager-triggered aborts from surfacing as errors during streaming.

@uinstinct uinstinct requested a review from a team as a code owner September 4, 2025 13:32
@uinstinct uinstinct requested review from RomneyDa and removed request for a team September 4, 2025 13:32
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 4, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 5, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2025
@tingwai tingwai merged commit 42414ee into continuedev:main Sep 5, 2025
83 of 85 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Got an AbortError2 when autocomplete
2 participants