include: libkrun: add krun_set_pidfile API
#401
Conversation
Add a new `krun_set_pidfile` API to allow the user to specify a path in which to write the current process's ID. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
|
I am not really a fan of this. Ideally this seems like something the user of this library should be responsible for. But I see your problem with that doing that - we don't have a clear point in the API where we finish building the VM and when when we are starting it. This could be solved more generally by having a function like Also another perspective: |
|
I agree that this is better done in the application using libkrun, which is also a better place to remove the pidfile on exit. The reason to create the pidfile as the last thing before we start the guest is to help the application detect successful start by waiting until the pidfile is created. But once the application detected that the vm was started, it needs to wait until the vm is accessible (e.g. via ssh). During this wait it can detect if libkrun failed after the pidfile was created. So I don't think we gain much by moving the functionality to libkrun. Cleaning up in libkrun is harder since it should not change process state like ataxia handler. The application using libkrun is a better place to manage process lifecycle. |
|
For cleanup: #373 is related. Ideally we would have a version of |
|
I did not that krun_start_enter does not return and call _exit. In this case the user cannot cleanup using atexit handler and this is a good reason to move the funcionallity into libkrun. But fixing clean to call exit() and let the user setup atexit handlers seems like a better approach. |
|
Closing based on feedback. Thanks all |
Yes, this one one of the reasons I thought it could be helpful here.
Also a fair point |
Add a new
krun_set_pidfileAPI to allow the user to specify a path in which to write the current process's ID.This was inspired by a new option I'm working on for krunkit: containers/krunkit#71. I figured it could be useful for users here as well.