Skip to content

ci: enable several rules from go-critic #12154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

ci: enable several rules from go-critic #12154

wants to merge 9 commits into from

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Jul 29, 2025 •
edited
Loading

@github-project-automation github-project-automation bot moved this to Needs Triage in Pull Request Review Jul 29, 2025
@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch 2 times, most recently from 684a64a to 2f4f8b5 Compare July 29, 2025 15:55
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch from 2f4f8b5 to 226ae5e Compare July 29, 2025 16:01
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch from 226ae5e to b0d2685 Compare July 29, 2025 16:04
@mmorel-35 mmorel-35 changed the title ci: enable-all rules from go-critic ci: enable several rules from go-critic Jul 29, 2025
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch from f4836e5 to ddfa128 Compare July 29, 2025 16:25
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch 5 times, most recently from b0f902e to 27ffbf1 Compare July 29, 2025 16:48
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch from 27ffbf1 to a790164 Compare July 29, 2025 16:53
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch 2 times, most recently from 5f8a491 to 02a28c6 Compare July 29, 2025 17:02
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch 2 times, most recently from c2f796e to e64a12e Compare July 29, 2025 17:15
@mmorel-35 mmorel-35 marked this pull request as ready for review July 29, 2025 18:51
@dosubot dosubot bot added area/toolchain Build and Release Toolchain go Pull requests that update Go code labels Jul 29, 2025
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch from e64a12e to fd8575b Compare July 30, 2025 05:59
@mmorel-35
ci: enable-all rules from go-critic
c7a4a31 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
ci: enable sloppyLen rule from go-critic
9f2b334 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
ci: enable ifElseChain rule from go-critic
44c511a 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
ci: enable singleCaseSwitch rule from go-critic
8a7da9e 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
ci: enable typeAssertChain rule from go-critic
49292cc 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
ci: enable httpNoBody rule from go-critic
8c85652 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
ci: enable elseif rule from go-critic
f289953 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
ci: enable deprecatedComment rule from go-critic
6c28a96 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
ci: enable octalLiteral rule from go-critic
b38a5a1 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the gocritic/enable-all branch from fd8575b to b38a5a1 Compare August 17, 2025 13:31
@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/toolchain Build and Release Toolchain go Pull requests that update Go code needs-ok-to-test needs-rebase size/XXL
Projects
Pull Request Review
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @k8s-ci-robot