-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add failing test for double build of compatible packages in test-package #18809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop2
Are you sure you want to change the base?
Add failing test for double build of compatible packages in test-package #18809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been investigating this a few hours, this is a very complex thing.
I'd say that the --compatible=build
should have been more limited and reduced in the scope in the first iteration, maybe something limiting to the conan create --build=compatible:&
use case.
There are cases that are not well defined, as using the validate()
with --build=compatible
that can actually pull an incompatible binary that would be rejected if the binary had been previously built.
The proposed fix is limited to the case of the local cache, but shouldn't remotes be taken into account too? The binary to be built maybe is already in the servers?
As this feature is Experimental, I propose to re-analyze the use case and scope first, problems that it is solving, alternate solutions, etc.
@memsharded thanks for the investigation. Just to clarify, the motivating case I described in #18803 is a plain and simple |
Thanks for the feedback. Yes, the problem is that the I need to investigate this a bit further, the |
oopsi, indeed I missed the
|
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
For #18803