Skip to content

Conversation

seferov
Copy link
Contributor

@seferov seferov commented Mar 27, 2016

No description provided.

@florianeckerstorfer
Copy link
Member

Could you add some tests for Azerbaijani?

@seferov
Copy link
Contributor Author

seferov commented May 12, 2016

@florianeckerstorfer added

@@ -45,6 +45,11 @@ public function setUp()
$this->slugify = new Slugify([], $this->provider);
}

public function tearDown()
{
Mockery::close();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seferov We don't need this here because the Mockery TestListeners is configured in the PHPUnit config (see)

@OskarStark
Copy link
Contributor

PR looks good to me 👍

@florianeckerstorfer florianeckerstorfer merged commit 922e56a into cocur:master May 12, 2016
@florianeckerstorfer
Copy link
Member

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants