Skip to content

Conversation

rohit-armorikar
Copy link

We have added few proposal for required indexing on tables.
Please review and let us know, which index out of the proposed one will help us for performance improvement.

Adding mysql proposed indexing change.
Adding file for postgres.
Adding file for hsqldb
Copy link

linux-foundation-easycla bot commented Mar 13, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@strehle
Copy link
Member

strehle commented Mar 13, 2025

@rohit-armorikar Thank you! We will check, please sign CLA as required step to accept your PR, thanks in advance

@strehle
Copy link
Member

strehle commented Mar 13, 2025

ok, you can and should run tests before the PR, see unit test failing because of index

org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.flywaydb.core.Flyway]: Factory method 'flyway' threw exception; nested exception is org.flywaydb.core.internal.command.DbMigrate$FlywayMigrateException: Migration V4_113__Add_Index_user_group_membership_groups.sql failed
-------------------------------------------------------------------
SQL State : 42000
Error Code : 1064
Message : (conn=53) You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IF EXISTS idx_users_zone_id_created ON users' at line 1
Location : org/cloudfoundry/identity/uaa/db/mysql/V4_113__Add_Index_user_group_membership_groups.sql (/root/uaa/server/build/resources/main/org/cloudfoundry/identity/uaa/db/mysql/V4_113__Add_Index_user_group_membership_groups.sql)

We run on MYSQL 5 and 8 and both fail.

With docker and this help you can run tests yourself.
https://github.com/cloudfoundry/uaa?tab=readme-ov-file#mysql

Corrected the issues with queries as per MySql 8 version.
@rohit-armorikar
Copy link
Author

@strehle Thanks for your input, we have corrected the changes and pushed the updates.
Please let us know if this is fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants