Changes to enable eventing to sidebar component #755

johnny-hsiao · 2022-06-28T17:36:09Z

We have plugins in the sidebar that needs to receive events from the backend to refresh on changes made.

To verify this change, you can make these changes:
app/models/conversation.rb
include Syncable

app/services/message_apis/inbox_sections/presenter.rb

def initialization_hook
    ...
          definitions: [
            {
              type: "content",
              events: ["new_item_received"]
            }
          ]
    ...
end

in rails console:
Conversation.last.notify_events_subscribers(, 'new_item_received',
{ conversation_key: })

* adding missing translation + switch * snack will dissapear after 2.5 secs * New translations en.yml (Catalan) * New translations en.yml (Ukrainian) * New translations en.yml (Turkish) * New translations en.yml (Chinese Simplified) * New translations en.yml (Vietnamese) * New translations en.yml (English) * New translations en.yml (Romanian) * New translations en.yml (Greek) * New translations en.yml (Korean) * New translations en.yml (Japanese) * New translations en.yml (Italian) * New translations en.yml (Hungarian) * New translations en.yml (Hebrew) * New translations en.yml (Finnish) * New translations en.yml (German) * New translations en.yml (Norwegian) * New translations en.yml (Danish) * New translations en.yml (Czech) * New translations en.yml (Arabic) * New translations en.yml (Afrikaans) * New translations en.yml (Spanish) * New translations en.yml (French) * New translations en.yml (Dutch) * New translations en.yml (Polish) * New translations en.yml (Swedish) * New translations en.yml (Portuguese) * New translations en.yml (Serbian (Cyrillic)) * New translations en.yml (Russian) * bots translations fix

* rubocoped , rubocop-rails * provisory revert * editor fix, avoid deep nesting of schema controls + task for clean * cy bot tasks fix * adding missing translation + switch * snack will dissapear after 2.5 secs * New translations en.yml (Catalan) * New translations en.yml (Ukrainian) * New translations en.yml (Turkish) * New translations en.yml (Chinese Simplified) * New translations en.yml (Vietnamese) * New translations en.yml (English) * New translations en.yml (Romanian) * New translations en.yml (Greek) * New translations en.yml (Korean) * New translations en.yml (Japanese) * New translations en.yml (Italian) * New translations en.yml (Hungarian) * New translations en.yml (Hebrew) * New translations en.yml (Finnish) * New translations en.yml (German) * New translations en.yml (Norwegian) * New translations en.yml (Danish) * New translations en.yml (Czech) * New translations en.yml (Arabic) * New translations en.yml (Afrikaans) * New translations en.yml (Spanish) * New translations en.yml (French) * New translations en.yml (Dutch) * New translations en.yml (Polish) * New translations en.yml (Swedish) * New translations en.yml (Portuguese) * New translations en.yml (Serbian (Cyrillic)) * New translations en.yml (Russian) * bots translations fix

* New translations en.yml (Catalan) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Russian) * New translations en.yml (Serbian (Cyrillic)) * New translations en.yml (Korean) * New translations en.yml (Dutch) * New translations en.yml (Norwegian) * New translations en.yml (Chinese Simplified) * New translations en.yml (Vietnamese) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Ukrainian) * New translations en.yml (Japanese) * New translations en.yml (Afrikaans) * New translations en.yml (Arabic) * New translations en.yml (Czech) * New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Danish) * New translations en.yml (Hebrew) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (German) * New translations en.yml (Greek) * New translations en.yml (Finnish) * New translations en.yml (Spanish)

* New translations en.yml (Catalan) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Russian) * New translations en.yml (Serbian (Cyrillic)) * New translations en.yml (Korean) * New translations en.yml (Dutch) * New translations en.yml (Norwegian) * New translations en.yml (Chinese Simplified) * New translations en.yml (Vietnamese) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Ukrainian) * New translations en.yml (Japanese) * New translations en.yml (Afrikaans) * New translations en.yml (Arabic) * New translations en.yml (Czech) * New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Danish) * New translations en.yml (Hebrew) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (German) * New translations en.yml (Greek) * New translations en.yml (Finnish)

* dark mode ready * cy specs fix, use data-cy * format * conversation buttons

* New translations en.yml (Catalan) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Russian) * New translations en.yml (Serbian (Cyrillic)) * New translations en.yml (Korean) * New translations en.yml (Dutch) * New translations en.yml (Norwegian) * New translations en.yml (Chinese Simplified) * New translations en.yml (Vietnamese) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Ukrainian) * New translations en.yml (Japanese) * New translations en.yml (Afrikaans) * New translations en.yml (Arabic) * New translations en.yml (Czech) * New translations en.yml (Romanian) * New translations en.yml (French) * New translations en.yml (Spanish) * New translations en.yml (Danish) * New translations en.yml (Hebrew) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (German) * New translations en.yml (Greek) * New translations en.yml (Finnish)

* monorepo, components / docs / messenger * packages set * hints + prettier * shared components into component * shared code * store + conversation port * components reference single file * store decoupled * editor decouple * update dante

* sliping away, fixes chaskiq#415 * change campaign name , tackles chaskiq#416 * field renderer fix

* campaign inbound email, disable reply from * quick replies fixes

* editor video less on mailing + phone attribute missing

* package validation phase * article update mutation permit null content * dialogflow integration event * peer deps on packages * issue template

* remove jsrassign * Remove hard coded email address * dialogflow query-params * days_ago translations * user state Co-authored-by: Kips <patrickjdavenport@gmail.com>

* New translations en.yml (Romanian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Russian) * New translations en.yml (Serbian (Cyrillic)) * New translations en.yml (Korean) * New translations en.yml (Dutch) * New translations en.yml (Norwegian) * New translations en.yml (Chinese Simplified) * New translations en.yml (Vietnamese) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Ukrainian) * New translations en.yml (Japanese) * New translations en.yml (Arabic) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (Afrikaans) * New translations en.yml (Danish) * New translations en.yml (Hebrew) * New translations en.yml (Hungarian) * New translations en.yml (Italian) * New translations en.yml (Greek) * New translations en.yml (Finnish)

* New translations en.yml (Chinese Simplified) * New translations en.yml (Chinese Simplified) * New translations en.yml (Chinese Simplified) * New translations definitions.en.yml (Chinese Simplified) * New translations doorkeeper.en.yml (Chinese Simplified) * New translations hints.en.yml (Chinese Simplified) * New translations subscriptions.en.yml (Chinese Simplified) * New translations en.yml (Chinese Simplified) * New translations definitions.en.yml (Chinese Simplified) * New translations doorkeeper.en.yml (Chinese Simplified) * New translations definitions.en.yml (Chinese Simplified) * New translations doorkeeper.en.yml (Chinese Simplified) * New translations devise_invitable.en.yml (Chinese Simplified) * New translations hints.en.yml (Chinese Simplified)

* New translations devise.en.yml (Chinese Simplified) * New translations doorkeeper.en.yml (Chinese Simplified) * New translations devise_invitable.en.yml (Chinese Simplified) * New translations subscriptions.en.yml (Chinese Simplified) * postcss 8, tailwind 2.1 * modal translations * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * complete missing translations * more on translations * more missing translations * google fonts support on banners * chinesse two letters change * closed at and allow replies on closed conversation settings * specs on inbound * inbound settings refactor, other tweaks * update gemfile * contact manager cc issue fix * button tab switch refactor * esm remove package * handle state change on conversation * conversation part delegate broadcast key

* New translations devise.en.yml (Chinese Simplified) * New translations doorkeeper.en.yml (Chinese Simplified) * New translations devise_invitable.en.yml (Chinese Simplified) * New translations subscriptions.en.yml (Chinese Simplified) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Romanian) * New translations definitions.en.yml (Finnish) * New translations definitions.en.yml (Hebrew) * New translations en.yml (Hebrew) * New translations en.yml (Finnish) * New translations en.yml (Hungarian) * New translations definitions.en.yml (Greek) * New translations en.yml (Greek) * New translations definitions.en.yml (Hungarian) * New translations definitions.en.yml (German) * New translations definitions.en.yml (Japanese) * New translations definitions.en.yml (Korean) * New translations en.yml (Korean) * New translations definitions.en.yml (Romanian) * New translations definitions.en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Japanese) * New translations en.yml (German) * New translations en.yml (Spanish) * New translations definitions.en.yml (Afrikaans) * New translations en.yml (Afrikaans) * New translations definitions.en.yml (Spanish) * New translations en.yml (French) * New translations definitions.en.yml (French) * New translations en.yml (Arabic) * New translations definitions.en.yml (Czech) * New translations definitions.en.yml (Arabic) * New translations en.yml (Danish) * New translations definitions.en.yml (Danish) * New translations en.yml (Czech) * New translations en.yml (Catalan) * New translations definitions.en.yml (Catalan) * New translations definitions.en.yml (Ukrainian) * New translations en.yml (Ukrainian) * New translations definitions.en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Chinese Simplified) * New translations en.yml (Swedish) * New translations definitions.en.yml (Vietnamese) * New translations en.yml (Vietnamese) * New translations definitions.en.yml (Chinese Simplified) * New translations definitions.en.yml (English) * New translations en.yml (English) * New translations definitions.en.yml (Swedish) * New translations en.yml (Polish) * New translations definitions.en.yml (Norwegian) * New translations definitions.en.yml (Polish) * New translations en.yml (Norwegian) * New translations definitions.en.yml (Dutch) * New translations en.yml (Dutch) * New translations definitions.en.yml (Serbian (Cyrillic)) * New translations en.yml (Serbian (Cyrillic)) * New translations en.yml (Portuguese) * New translations definitions.en.yml (Russian) * New translations en.yml (Russian) * New translations definitions.en.yml (Portuguese) * fix translations

* playground components * reports sections + new dashboard view * adjust dark colors * disable renderer app package on agent conversation (chat) * new switch control on sidebar / sidebar toggle children * csat package + reports * fix specs + rubocop

Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/sporkmonger/addressable/releases) - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](sporkmonger/addressable@addressable-2.7.0...addressable-2.8.0) --- updated-dependencies: - dependency-name: addressable dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* put some packages on dev * updated yarn deps * internal package socket * put on hold event, kredis access simplification * handlers api, on hold behavior * Update app/services/message_apis/twilio_phone/api.rb

…iq#741)

…e), name and email. (chaskiq#744)

* Twilio thread slicing * start conversation from the inbox * initiator channel on start conversation, handle fail on Graphql client, * clean editor EEDropdown * handle errors on email hook and action trigger * new conversation state refactor

* use ruby 2.7.5 * revert hash syntax on cop * remove borales yarn * bundler version and uri fix

Co-authored-by: Johnny Hsiao <johnny.hsiao@thinkresearch.com>

CLAassistant · 2022-06-28T17:36:22Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 7 committers have signed the CLA.

✅ michelson
✅ menfs-at-think
❌ dependabot[bot]
❌ marcbest
❌ marinaxkonsta
❌ johnny-hsiao
❌ johnnythinks
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

michelson · 2022-06-28T18:08:24Z

app/javascript/src/pages/conversations/Sidebar.tsx

@@ -12,6 +12,7 @@ import I18n from '../../shared/FakeI18n';
 import RestrictedArea, {
  allowedAccessTo,
 } from '@chaskiq/components/src/components/AccessDenied';
+import { useEventBroker } from '../../shared/EventBroker';


why not use the messages from cableApp in Appcontainer.tsx?

qlty-cloud-legacy · 2022-06-29T19:46:36Z

app/javascript/src/shared/EventBroker.tsx

+  | 'PresenceChannel'
+  | 'AgentChannel';
+
+export function useEventBroker(


Function useEventBroker has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

michelson · 2022-06-29T23:05:59Z

app/javascript/src/pages/conversations/Sidebar.tsx

@@ -19,14 +19,43 @@ function localeDate(date) {
  return new Date(date).toLocaleString();
 }

+export const eventsSubscriber = (appId, cableApp, callback) => {


Hi @johnny-hsiao I still not sure why is there is a new subscription to cable instead of leveraging the events provided on AppContainer.tsx.

michelson · 2022-07-01T16:29:00Z

app/javascript/src/shared/actionCableSubscription.ts

@@ -83,6 +84,7 @@ export const eventsSubscriber = (appId, cableApp, dispatch, fetchApp) => {
              ?.contentWindow;
            popup && popup.postMessage(data, '*');
          default:
+            dispatch(appEventReceived(data))


I would prefer to add a specific type of handling for this, appEvent is too general, if this event is intended for AppPackages let's name this AppPackage event, and handle this with app_package on the data.type

…n package definitions to have events added

qlty-cloud-legacy · 2022-07-04T19:44:54Z

Code Climate has analyzed commit 7652ed4 and detected 0 issues on this pull request.

View more on Code Climate.

michelson and others added 30 commits June 5, 2021 12:44

translations on bot tabs

0b769f1

dark mode ready (chaskiq#412)

9aa3c05

* dark mode ready * cy specs fix, use data-cy * format * conversation buttons

Help center path (chaskiq#419)

af5294e

* monorepo, components / docs / messenger * packages set * hints + prettier * shared components into component * shared code * store + conversation port * components reference single file * store decoupled * editor decouple * update dante

Field renderer fix (chaskiq#420)

f0e23d4

* sliping away, fixes chaskiq#415 * change campaign name , tackles chaskiq#416 * field renderer fix

quick replies fix (chaskiq#421)

efd159e

* campaign inbound email, disable reply from * quick replies fixes

Field renderer fix (chaskiq#422)

884827d

* editor video less on mailing + phone attribute missing

Articles null content (chaskiq#425)

b27959e

* package validation phase * article update mutation permit null content * dialogflow integration event * peer deps on packages * issue template

issue template

698feed

Update issue templates

acaee84

remove yml issue templates

1e14ded

Fix an incorrectly labelled form field (chaskiq#430)

f88294c

Fixes jun (chaskiq#435)

a1715d0

* remove jsrassign * Remove hard coded email address * dialogflow query-params * days_ago translations * user state Co-authored-by: Kips <patrickjdavenport@gmail.com>

New translations en.yml (Chinese Simplified)

03a9a7e

New translations devise.en.yml (Chinese Simplified)

c594530

New translations subscriptions.en.yml (Chinese Simplified)

68c9ccc

Merge remote-tracking branch 'origin/l10n_master2'

3b49ea9

chinese lang

be1bfe4

set amazon ses region server for non us- regions (chaskiq#445)

acb451b

empty package skip notification (chaskiq#446)

9424763

Components playground (chaskiq#447)

b0655aa

* playground components * reports sections + new dashboard view * adjust dark colors * disable renderer app package on agent conversation (chat) * new switch control on sidebar / sidebar toggle children * csat package + reports * fix specs + rubocop

michelson and others added 14 commits May 16, 2022 16:55

Telephony hold (chaskiq#739)

ef70d5d

* put some packages on dev * updated yarn deps * internal package socket * put on hold event, kredis access simplification * handlers api, on hold behavior * Update app/services/message_apis/twilio_phone/api.rb

Update LICENSE.txt

bffd028

trigger factory does not remove, fix closed state on live chat (chask…

0ec780c

…iq#741)

move esbuild to dev deps

5ba6b50

Merge branch 'stage'

b57f016

Set text overflow to ellipsis for FilterMenu items. (chaskiq#743)

9ef80e7

allow searching conversations by fullname(first_name + ' ' + last_nam…

7815c4a

…e), name and email. (chaskiq#744)

Start conversation thread (chaskiq#745)

72fd6f6

* Twilio thread slicing * start conversation from the inbox * initiator channel on start conversation, handle fail on Graphql client, * clean editor EEDropdown * handle errors on email hook and action trigger * new conversation state refactor

use ruby 2.7.5 (chaskiq#748)

8fb33b3

* use ruby 2.7.5 * revert hash syntax on cop * remove borales yarn * bundler version and uri fix

docker image

3829898

downgrade sidekiq

63c18bb

deps (chaskiq#750)

6aaa24e

Remove x-frame-option for the remaining iframe code path (chaskiq#752)

bf0000a

Co-authored-by: Johnny Hsiao <johnny.hsiao@thinkresearch.com>

Changes to enable eventing to sidebar component

140a591

michelson reviewed Jun 28, 2022

View reviewed changes

qlty-cloud-legacy bot reviewed Jun 29, 2022

View reviewed changes

Use cableApp from AppContainer for sidebar events

b8ee42f

johnny-hsiao force-pushed the eventing-to-sidebar branch from 07c132b to b8ee42f Compare June 29, 2022 19:49

michelson reviewed Jun 29, 2022

View reviewed changes

Refactor to re-use eventSubscriber

28e5f4e

johnny-hsiao force-pushed the eventing-to-sidebar branch from b261976 to e844eb0 Compare June 30, 2022 21:44

Rename action type

428b61c

johnny-hsiao force-pushed the eventing-to-sidebar branch from e844eb0 to 428b61c Compare June 30, 2022 21:48

michelson reviewed Jul 1, 2022

View reviewed changes

Rename to app package event

c599188

johnny-hsiao force-pushed the eventing-to-sidebar branch from 6512dcb to c599188 Compare July 4, 2022 14:04

Use app package id and command in socket message instead of relying o…

7652ed4

…n package definitions to have events added

michelson force-pushed the master branch from 37f1e20 to dfd2aab Compare April 12, 2023 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Changes to enable eventing to sidebar component #755

Changes to enable eventing to sidebar component #755

Uh oh!

johnny-hsiao commented Jun 28, 2022

Uh oh!

CLAassistant commented Jun 28, 2022 •

edited

Loading

Uh oh!

michelson Jun 28, 2022

Uh oh!

qlty-cloud-legacy bot Jun 29, 2022

Uh oh!

michelson Jun 29, 2022

Uh oh!

michelson Jul 1, 2022

Uh oh!

qlty-cloud-legacy bot commented Jul 4, 2022

Uh oh!

Uh oh!

Changes to enable eventing to sidebar component #755

Are you sure you want to change the base?

Changes to enable eventing to sidebar component #755

Uh oh!

Conversation

johnny-hsiao commented Jun 28, 2022

Uh oh!

CLAassistant commented Jun 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michelson Jun 28, 2022

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Jun 29, 2022

Choose a reason for hiding this comment

Uh oh!

michelson Jun 29, 2022

Choose a reason for hiding this comment

Uh oh!

michelson Jul 1, 2022

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot commented Jul 4, 2022

Uh oh!

Uh oh!

CLAassistant commented Jun 28, 2022 •

edited

Loading